Open
Conversation
BenjaminMichaelis
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
BenjaminMichaelis
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This pull request introduces cross-platform and cross-browser matrix testing for integration tests. The key objectives are to enable comprehensive testing across Windows, Linux, and macOS operating systems using Chromium, Firefox, and WebKit browsers, and to properly separate integration tests from unit tests in the CI/CD pipeline.
Changes:
- Updated npm registry configuration across multiple packages to use the public npmjs.org registry
- Added matrix testing strategy to GitHub Actions workflow for integration tests across 3 operating systems and 3 browsers (9 total combinations)
- Enhanced PlaywrightSession to support browser selection via parameter or environment variable
- Added
[Trait("TestType", "Integration")]to integration test classes to enable test filtering - Removed Linux-specific test skipping logic from IntegrationTestFactAttribute
- Updated deployment configuration with new Azure Container Registry secret names
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/microsoft-trydotnet/.npmrc | Changed npm registry from Azure DevOps to public npmjs.org |
| src/microsoft-trydotnet-styles/.npmrc | Changed npm registry from Azure DevOps to public npmjs.org |
| src/microsoft-trydotnet-editor/.npmrc | Changed npm registry from Azure DevOps to public npmjs.org |
| src/microsoft-learn-mock/.npmrc | Changed npm registry from Azure DevOps to public npmjs.org |
| src/Microsoft.TryDotNet.IntegrationTests/WasmRunnerTests.cs | Added Integration trait for test filtering |
| src/Microsoft.TryDotNet.IntegrationTests/TryDotNetJsIntegrationTests.cs | Added Integration trait for test filtering |
| src/Microsoft.TryDotNet.IntegrationTests/PlaywrightSession.cs | Added multi-browser support with environment variable and parameter-based browser selection |
| src/Microsoft.TryDotNet.IntegrationTests/Microsoft.TryDotNet.IntegrationTests.csproj | Added global using for Xunit and removed trailing whitespace |
| src/Microsoft.TryDotNet.IntegrationTests/IntegrationTestFactAttribute.cs | Removed Linux-specific test skipping to enable cross-platform testing |
| src/Microsoft.TryDotNet.IntegrationTests/EditorTests.cs | Added Integration trait for test filtering |
| .github/workflows/Build-Test-And-Deploy.yaml | Added matrix testing strategy, updated test filters, changed ACR secret names |
| .github/actions/setup-dotnet/action.yml | Added configurable build configuration parameter (Release/Debug) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BenjaminMichaelis
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
BenjaminMichaelis
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
BenjaminMichaelis
deployed
to
BuildAndUploadImage
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.